Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

[WIP] Feature/olehs datacite usage tracker#2496

Closed
opaduchak wants to merge 2 commits intoCenterForOpenScience:feature/datacite-usage-trackerfrom
opaduchak:feature/olehs-datacite-usage-tracker
Closed

[WIP] Feature/olehs datacite usage tracker#2496
opaduchak wants to merge 2 commits intoCenterForOpenScience:feature/datacite-usage-trackerfrom
opaduchak:feature/olehs-datacite-usage-tracker

Conversation

@opaduchak
Copy link
Copy Markdown
Contributor

  • Ticket: []
  • Feature flag: n/a

Purpose

Summary of Changes

Screenshot(s)

Side Effects

QA Notes

@opaduchak opaduchak changed the base branch from develop to feature/datacite-usage-tracker January 30, 2025 15:15
@futa-ikeda
Copy link
Copy Markdown
Contributor

Dang, looking at the build failure, it seems like the build process is looking for vanilla JS and is getting a TS file

Module build failed (from ./node_modules/ember-auto-import/node_modules/babel-loader/lib/index.js):
SyntaxError: /home/runner/work/ember-osf-web/ember-osf-web/node_modules/datacite-tracker/src/index.ts: Missing semicolon. (11:15)

   9 |     if (scriptEl) {
  10 |         // Find the DOI
> 11 |         let doi: string = ""
     |                ^
  12 |
  13 |         // Get DOI from the dataset tag always as preferred
  14 |         doi = scriptEl.dataset.doi || "";

Not sure how hard it would be to address this, but would you mind seeing if it's an easy/stable/reasonable fix?

@opaduchak opaduchak closed this Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants